[injector-helpers] injector-helpers plugin fails to load domhandler@^3

[t2ym]

[injector-helpers] injector-helpers plugin fails to load domhandler@^3

Root Cause

• When node_modules/thin-hook/node_modules/domhandler is @^2 and node_modules/domhandler is @^3, node_modules/@thin-hook/injector-helpers/node_modules/domhandler is inexistent
• node_modules/@thin-hook/injector-helpers/configurator.js fails to load domhander@^3 since node_modules/thin-hook/node_modules/domhandler overrides the resolution

Workaround

• Install domhandler@^2 to set versions as follows
  • node_modules/domhandler --- @^2
  • node_modules/@thin-hook/injector-helpers/node_modules/domhandler --- @^3

    npm i -D domhandler@^2

Ad-hoc Fix

• Avoid loading domhandler@2 under node_modules/thin-hook/node_modules

  
  diff --git a/plugins/injector-helpers/configurator.js b/plugins/injector-helpers/configurator.js
  index 00b44a66..c0fa1dee 100644
  --- a/plugins/injector-helpers/configurator.js
  +++ b/plugins/injector-helpers/configurator.js
  @@ -8,7 +8,16 @@ const { HtmlInjectionHandlerFactory } = require('target-injector/HtmlInjectionHa
  const { JsInjectionHandlerFactory } = require('target-injector/JsInjectionHandlerFactory.js');
  
  const { Parser } = require("htmlparser2");
  -const { DomHandler } = require("domhandler");
  +const { DomHandler } = require("domhandler").DomHandler

• ? require("domhandler") // domhandler@3
• : require(require.resolve("domhandler", { // avoid loading domhandler@2, which is a dependency of htmlparser2@3.9.2
• paths: require.resolve.paths("domhandler")
• .filter(_path =>
• !_path.endsWith('/thin-hook/plugins/injector-helpers/node_modules') &&
• !_path.endsWith('/thin-hook/plugins/node_modules') &&
• !_path.endsWith('/thin-hook/node_modules')
• )

• })); const cssauron = require('cssauron');

  const parser = require('espree'); // can be esprima or acorn

Fundamental Fix

• Upgrade htmlparser2@3.9.2 to @4, which depends on domhandler@^3
  • Requires updates in lib/preprocess.js