[rollup] import.meta.url is not properly resolved in rollup

[t2ym]

[rollup] import.meta.url is not properly resolved in rollup

Root Cause

• A valid resolveImportMeta() callback is missing in rollup configufation
• The raw import.meta.url value for the bundle file is unexpectedly provided

Reproducible Steps

• In demo-raw/index.html, import the bundled rollup-module1.js instead of the raw module modules/module1.js

Fix

• Add a rollup plugin with a valid resolveImportMeta() callback
  • Limitation: If the bundle file is moved to a different URL path after the build, the resolved value might become invalid
• Adjust the related demo assertions

  
  diff --git a/demo-config/config.js b/demo-config/config.js
  index 7d4c7b07..4f4d4539 100644
  --- a/demo-config/config.js
  +++ b/demo-config/config.js
  @@ -801,6 +801,19 @@ class TargetConfig extends Injectable(Traceable(Configurable(GulpDefaultRegistry
         input: path.resolve(target.entryBase, target.entry),
         treeshake: false,
         plugins: [

• {
• name: 'import-meta-url-current-module',
• resolveImportMeta(property, { moduleId }) {
• if (property === null) { // import.meta is always separated from url property in hooked code
• const url = `new URL('${path.relative(
• path.dirname(path.resolve(target.entryBase, target.output)) + '/',
• moduleId
• )}', import.meta.url).href`;
• return ({ url: ${url} });
• }
• return null;
• }
• }, this.bundles.components.rollupPluginBrowserifyTransform( this.bundles.components.hookTransformFactory('rollup', target, this.bundles.components.importMapperFactory, this.bundles.components.contextGeneratorHelper) ), diff --git a/demo-raw/modules/module1.js b/demo-raw/modules/module1.js index 6f204a89..8438b6fb 100644 --- a/demo-raw/modules/module1.js +++ b/demo-raw/modules/module1.js @@ -21,8 +21,9 @@ import { } from "./module2.js"; import { UnspecifiedExport } from "./module3.js";

+chai.assert.isOk(import.meta.url.endsWith('modules/module1.js'), "import.meta.url.endsWith('modules/module1.js') " + import.meta.url); import("lit-html").then(dynamicModule => {

• if (import.meta.url.indexOf('rollup') >= 0) {
• if (dynamicModule !== litHtmlNamespace) { console.warn('dynamically imported "lit-html" module may conflict with that in this bundle ', import.meta.url); } else {