t2ym / thin-hook

Thin Hook Preprocessor

Other

4 stars 1 forks source link

[non-js-imports] Importing ./directory/index.js via ./directory fails #438

Closed t2ym closed 1 year ago

t2ym commented 1 year ago

[non-js-imports] Importing ./directory/index.js via ./directory fails

Root Cause

import "./submodule" fails to import "./submodule/index.js" as the import map entry is missing

Fix

Whenever ".../directory/index.js" is found, add an import map entry to resolve ".../directory" to ".../directory/index.js"

Note: As a side-effect, importing via ".../directory/index" is disabled, which should be a good practice


diff --git a/demo-config/config.js b/demo-config/config.js
index c0c302ca..fdfce6af 100644
--- a/demo-config/config.js
+++ b/demo-config/config.js
@@ -761,6 +761,10 @@ class TargetConfig extends Injectable(Traceable(Configurable(GulpDefaultRegistry
   if (href.match(/[.](css|svg)[.]js$/)) {
     done(false, false); // skip processed JavaScripts
   }

else if (href.match(/\/index[.]js$/)) {
href = href.replace(/\/index[.]js$/, '');
done(false, true); // resolve extension-less directory name
} else { href = href.replace(/[.]js$/, ''); done(false, true); // resolve extension-less name