t3-innovation-network / desm

Data Ecosystem Schema Mapper
Apache License 2.0
10 stars 4 forks source link

Question about showing person information on mappings #542

Closed philbarker closed 3 months ago

philbarker commented 3 months ago

I see this is added to the public mapping screen:

image

(This image from https://tool.desmsolutions.org/mappings-list?cp=1&abstractClass=Competence )

Is there a reason for showing this information? I've seen it on staging and assumed it was some debug info, but now it is showing on the T3 instance. I'm kind of wary about showing any personal information without good reason.

jeannekitchens commented 3 months ago

@philbarker @edgarf I think it's useful to include the specification names and laste updated dates. Otherwise, it's not possible to know how dated or not a mappigng is. Remove the names of the mappers though.

philbarker commented 3 months ago

OK, show the Specifications and Dates, but can we please make sure it is the specification names and versions (not the organization of the mapper) that displays. And there is no need to show the abstract domain being mapped. It looks like currently every update is being shown, we only need the latest update.

The names of the specifications and versions should also be what shows in the "show alignment specifications" drop-down (currently it too shows the organization):

image

excelsior commented 3 months ago

@philbarker The current format is <Organization> (<version>) updated on <date> or <Organization> updated on <date> if there's no version.

philbarker commented 3 months ago

can we please make sure it is the specification names and versions (not the organization of the mapper)

philbarker commented 3 months ago

@excelsior what is showing on the Cred Eng instance is still not right.

It shows this:

image

To repeat here what I said on slack: "The drop down should only show the alignment specifications for the abstract domain and project being viewed. This is what shows for the "Shared mapping list". It'll be the same specifications showing in the drop down as show in the list of specifications mapped."

Look at https://desm.credentialengine.org/mappings-list?abstractClass=Micro-credential+Claimed&cp=6 All the specification names are showing in the drop-down, even though only one is available in the mapping for this abstract class. I don't understand why you would show options in a drop down for which no mappings can be shown.

philbarker commented 3 months ago

PS. if we can have the dates for the last-update of the mappings back, that would be great too.