search

t3-oss / create-t3-app

The best way to start a full-stack, typesafe Next.js app
https://create.t3.gg
MIT License
24.36k stars 1.11k forks source link

feat: NextAuth documentation update for app router #1882

Open akshithio opened 2 months ago

akshithio commented 2 months ago

Is your feature request related to a problem? Please describe.

The NextAuth documentation describes the use of <SessionProvider /> that is the recommended practice for versions of Next.js prior to 14. The documentation also doesn't reflect the actual state of create-t3-app since it now uses the getServerSession hook instead and the page routing alongside the code snippets are not up to date.

Describe the solution you'd like to see

An update to the documentations describing the use of getServerSession alongside updated code snippets that match the repository and matching explanations.

Describe alternate solutions

Provide a user alert at the top of the page stating that the documentation may be outdated and is currently being updated to reflect the actual state of create-t3-app

Additional information

No response

akshithio commented 2 months ago

I'd be happy to potentially send in a pull request that updates documentation for this specific page, unless the team is working on some sort of complete overhaul on documentation for the /app router updates and if such a PR would interfere with that process.

juliusmarminge commented 2 months ago

I'd be happy to potentially send in a pull request that updates documentation for this specific page, unless the team is working on some sort of complete overhaul on documentation for the /app router updates and if such a PR would interfere with that process.

No, we don't really have the manpower to do that so we're relying on the community for these things. Would love to accept a PR :)

DigitalNaut commented 2 months ago

I'd suggest upping the priority on this one. As a new user, this project has a steep learning curve and it's more pronounced with outdated documentation.

akshithio commented 2 months ago

Working on it since yesterday (had school before that)! In all honesty I think essentially alerting to the fact that the Client Provider section is in some sense outdated and slightly editing the server side information is all that it takes considering that not a whole lot has technically changed. create-t3-app seems to have had support for server-side auth much before it was the "recommended" way to do things. Seems like it's a smaller change than I had initially thought it would be when I wrote the issue and I'm working on it!