search

t3-oss / create-t3-app

The best way to start a full-stack, typesafe Next.js app
https://create.t3.gg
MIT License
25.51k stars 1.17k forks source link

feat: Use docker compose instead of a single docker container #1927

Open TheDevilOnLine opened 4 months ago

TheDevilOnLine commented 4 months ago

Is your feature request related to a problem? Please describe.

A lot of our developers work on Windows and running start-database.sh requires a bunch of extra steps

Describe the solution you'd like to see

start-database.sh suggest running itself in WSL, but I think it would be way easier to supply a docker-compose.yml. This also allows for random password generation to be used in the docker-compose.yml and in the .env file.

Describe alternate solutions

N/A

Additional information

If people are interested in this solution, I can make a pull request with the suggested functionality.

datasalaryman commented 4 months ago

Hi, to clarify, do you see the server and client parts of the nextjs to be separate docker containers? or something else?

TheDevilOnLine commented 4 months ago

@datasalaryman just the database (so the stuff that's currently being started into docker when you run the start-database.sh command)

datasalaryman commented 4 months ago

@TheDevilOnLine so the docker-compose file will be structured like this?

services:
  web:
    ...
  postgres:
    ...

okay, I'll see if I can take that on