search

t3-oss / create-t3-turbo

Clean and simple starter repo using the T3 Stack along with Expo React Native
https://turbo.t3.gg
MIT License
4.73k stars 408 forks source link

chore: repo maintenance, bump deps, cleanup configs #1144

Closed ahkhanjani closed 3 months ago

ahkhanjani commented 3 months ago

Tidied up config files and updated deps, node and pnpm versions.

ahkhanjani commented 3 months ago

I don't think there is any need for tailwind.config.ts and its dependencies in the UI package. Can anyone please confirm this?

ahkhanjani commented 3 months ago

@juliusmarminge When do we default to /src/**/*.ts and use generated .d.ts files like in validators package? I don't know why sometimes we would use generated .js files and sometimes just the .ts files. Could you please explain?

I have enabled emitDeclarationOnly for the validators package since we're not using .js files but I suspect I lack the required TS knowledge to understand something here.

juliusmarminge commented 3 months ago

The declaration is mainly to speed up typescript editor performance since it's faster to scan d.ts files than inferring from .ts files.

The transpiled .js isn't really the point, especially since Next.js still transpiles on it's own. We can unify and only have emitDeclarationOnly on all packages if you think that's less mental overhead

ahkhanjani commented 3 months ago

The transpiled .js isn't really the point, especially since Next.js still transpiles on it's own. We can unify and only have emitDeclarationOnly on all packages if you think that's less mental overhead

That would be awesome. Let's go with that

ahkhanjani commented 3 months ago

I think we're good to go @juliusmarminge. Please review

ahkhanjani commented 3 months ago

@juliusmarminge I did not update the React Native libraries since I didn't wanna break anything. Could you please look into that? Or should I leave them as they are?

juliusmarminge commented 3 months ago

I did not update the React Native libraries since I didn't wanna break anything

Let's do that in a separate one. React Native 0.75 was just released so I'm guessing there's gonna be a new Expo update etc soon