search

t3-oss / create-t3-turbo

Clean and simple starter repo using the T3 Stack along with Expo React Native
https://turbo.t3.gg
MIT License
4.57k stars 384 forks source link

feat: shadcn-ui cli working in packages/ui #956

Closed trevorpfiz closed 5 months ago

trevorpfiz commented 6 months ago

I was able to follow https://github.com/dan5py/turborepo-shadcn-ui and get the shadcn-ui cli working in packages/ui.

The only catch is the folder structure of packages/ui is not as clean, but it follows the standard pattern. Also had to add "@acme/ui/*": ["../../packages/ui/src/*"] to the nextjs tsconfig.json as outlined in https://github.com/dan5py/turborepo-shadcn-ui/issues/20

Seems like the pros outweigh the cons though.

juliusmarminge commented 5 months ago

Thanks for the PR. However I don't want to move all the components 2 levels deep for "no" reason. I'll just add the workaround with the self-referncing to cn() in the orginal PR