search

t3-oss / t3-env

https://env.t3.gg
MIT License
2.45k stars 79 forks source link

refactor: remove dependency on z.object #210

Open decs opened 3 months ago

decs commented 3 months ago

refactor: remove dependency on z.object

Summary: A step towards addressing #6. This PR removes the z.object internal wrapper. There's a breaking change on the onValidationError function, but it should be minor.

Test Plan:

bun run build
bun run test
vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
t3-env ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 7:30am
vercel[bot] commented 3 months ago

@decs is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

juliusmarminge commented 3 months ago

Thanks for the PR, but I'm a bit confused. How is this better than what we have and how does it progress towards the linked issue? The goal is to have the user pass in a ZodObject instead of a record. Maybe I am missing something?