search

t3brightside / youtubevideo

TYPO3 CMS extension for easy to use YouTube content element with cover image and title.
https://t3brightside.com
Other
4 stars 5 forks source link

Ideas for youtubevideo.js #1

Closed SicorDev closed 6 years ago

SicorDev commented 6 years ago

Hi, nice extension - thank you very much!

We had to replace $( with jQuery( in youtubevideo.js to make it work, maybe you want to change that in a future release as well.

We also moved the "small" CSS breakpoint from 600 to 400, as it's still looking good for us.

Maybe you can make the breakpoint location configurable. Or add a plugin option / constant to manually decide wether it should add "small" or not.

Greetings, Manuel

t3brightside commented 6 years ago

Thanks for the feedback. Will take it under consideration, no conflict jQuery makes sense. Breakpoint configuration in template constants makes sense. For the next version I think I'll drop these things in.

t3brightside commented 6 years ago

Both features are available in the version 1.2.4 now!

SicorDev commented 6 years ago

Thank you very much!