search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
366 stars 104 forks source link

Support all params #18

Closed masterT closed 9 years ago

masterT commented 9 years ago

Support any params in the query, this way it is possible to fully use the ItemLookup and ItemSearch methods.

See pull request #16

masterT commented 9 years ago

The tests are passing on my computer, I don't get it. 

$ npm test

> amazon-product-api@0.2.4 test /Users/simon/Documents/personal/progr_stuff/sources/amazon-product-api-forked
> mocha

child_process: customFds option is deprecated, use stdio instead.

  generateQueryString(query, method, credentials)
    ✓ should return a string

  createClient(credentials)
    ✓ should return amazon product api client with item search method

  client.itemSearch(query, cb)
    when credentials are valid
      when no callback is passed
        ✓ should return search results from amazon (456ms)
        ✓ should work with custom domain (706ms)
      when callback is passed
        ✓ should return search results from amazon (334ms)
    when credentials are invalid
      when no callback is passed
        ✓ should return an error (127ms)
      when callback is passed
        ✓ should return an error (136ms)

  query string
    ✓ should be a valid url
    ✓ should include a valid timestamp
    ✓ should include keywords
    ✓ should be signed

  11 passing (2s)
t3chnoboy commented 9 years ago

sweet!

masterT commented 9 years ago

Thanks! It looks like if the credentials were not set during the tests.

t3chnoboy commented 9 years ago

Looks very good! I can add you to the repo as a collaborator if you don't mind.

masterT commented 9 years ago

That would be great thanks.

t3chnoboy commented 9 years ago

Done! What's your npm username?

masterT commented 9 years ago

It's mastert!

t3chnoboy commented 9 years ago

:+1: Can you publish the latest version? There are lots of changes. I think we should bump minor version. So it should be 0.3.0

masterT commented 9 years ago

Yeah that makes a sens!