search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
366 stars 104 forks source link

Support operation BrowseNodeLookup #19

Closed kaue closed 9 years ago

kaue commented 9 years ago

I am not sure why Travis is returning this errors, i was able to test in my computer.

masterT commented 9 years ago

I don't know why, checks failed on my PR too #18. Maybe @t3chnoboy knows why.

masterT commented 9 years ago

I would be nice to update the README and maybe add an example in the ./examples dir to show how to use the new feature.

t3chnoboy commented 9 years ago

@masterT @kauegimenes Build is green on master though... Looks like something wrong with travis config for PRs. Anyway, we need to update travis config. They've switched to containers recently.

t3chnoboy commented 9 years ago

lgtm, @kauegimenes can you please fix the indentation?

kaue commented 9 years ago

@t3chnoboy @masterT I just included the example, updated the readme and fixed the identation.

masterT commented 9 years ago

:+1: Nice!

masterT commented 9 years ago

@t3chnoboy ready for merge/bump version/publish? Do you want me to do it ?

t3chnoboy commented 9 years ago

Yep! Good to merge :+1: