Closed masterT closed 9 years ago
All checks have passed
whoa. PR checker works now!
Now I don't see the point of having a variable defaultParams. I could refactor a little more and change this:
// Default
defaultParams['SearchIndex'] = 'All';
defaultParams['Condition'] = 'All';
defaultParams['ResponseGroup'] = 'ItemAttributes';
defaultParams['Keywords'] = '';
defaultParams['ItemPage'] = '1';
params = setDefaultParams(params, defaultParams);
to that:
// Default
params = setDefaultParams(params, {
SearchIndex: 'All',
Condition: 'All',
// ...
});
@t3chnoboy what do you think?
sweet! Thanks a lot for what you are doing to this project!
You are welcomed! :blush:
I think everything is good now.
@t3chnoboy I will merge/dump version/publish good ?
yep! shipit :ship:
that was fast :car:
:information_desk_person:
Fix issue #20