search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
365 stars 104 forks source link

Fix for BrowseNodeLookup support in the callback. #23

Closed Codepoet77 closed 8 years ago

Codepoet77 commented 8 years ago

Fix to support BrowseNodeLookup in the callback. Other minor non functional changes that you will notice are formatting changes to make it consistent. Spaces before parens are fairly standard and pass JSHint as well.

masterT commented 8 years ago

Did the tests pass on your local machine? I think the credentials are not set correctly on travis-ci when your are not on the branch master.

It looks good, but I think we should do one of the options below:

  1. put space everywhere before function's parenthesis
  2. don't put space before function's parenthesis

What do you think @t3chnoboy @Codepoet77?

Codepoet77 commented 8 years ago

@t3chnoboy @masterT I am using Adobe Brackets and it doesn't even have the option to not have a space after a function. The auto beautify feature automatically does this. I'm pretty sure this is common place now. I also read up on it as well and it seems like it is a preference in many Stackoverflow articles.

Let me know what you guys think.

masterT commented 8 years ago

@Codepoet77 @t3chnoboy I don't really mind haha, but as I said, it should be everywhere or nowhere.

Codepoet77 commented 8 years ago

Made the formatting change.

masterT commented 8 years ago

Good :+1: !

masterT commented 8 years ago

@Codepoet77 @t3chnoboy I just published the new version on npm.

t3chnoboy commented 8 years ago

Cool! thank you!