search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
365 stars 104 forks source link

Update API version for ItemLookup to 2013-08-01 #35

Closed FdezRomero closed 8 years ago

FdezRomero commented 8 years ago

Changed API version from 2011-08-01 to 2013-08-01 when using the ItemLookup method as discussed in #26. All tests are passing OK.

You may want to update the dependencies (the badge is showing yellow at the moment) and bump the package version to NPM afterwards.

Thanks!

t3chnoboy commented 8 years ago

Great! Thanks @FdezRomero I'll publish a new version.

FdezRomero commented 8 years ago

Awesome! Thanks @t3chnoboy

t3chnoboy commented 8 years ago

@masterT @JuanCrg90 Can you guys please publish a new version? I got problems with my private npm server and npm registry configuration :grin:

masterT commented 8 years ago

All right :ship:!

masterT commented 8 years ago

@t3chnoboy @FdezRomero Something is broken!

masterT commented 8 years ago

@t3chnoboy @FdezRomero First time the specs were run by Travis CI, some did not passed. Amazon returns an unexpected error because there were to much request sent in a too short time.

I will update the specs now so it won't happened again.

masterT commented 8 years ago

Here is the Amazon error:

$: { xmlns: 'http://ecs.amazonaws.com/doc/2013-08-01/' },
  Error: [
    {
      Code: [ 'RequestThrottled' ],
      Message: [
        'AWS Access Key ID: AKIAIXILNIR67IOXLNHA. You are submitting requests too quickly. Please retry your requests at a slower rate.'
      ]
    }
  ],
  RequestId: [ '6a410764-3977-4149-bdfd-383893c15992' ]
}
arjunkori commented 7 years ago

Same here, I am getting the same error as @masterT mentioned above.

masterT commented 7 years ago

This is because you have a maximum rate of 1 request per seconde per IP address. You need to throttle your request. @arjunkori check the issue #37.