search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
365 stars 104 forks source link

Adding new tests for CartCreate #38

Open donovanh opened 8 years ago

donovanh commented 8 years ago

I've forked this and added a "CartCreate" option here: https://github.com/donovanh/amazon-product-api

Having some trouble with the tests though - I think it could be a throttling issue as it hits Amazon's API repeatedly, so I'm seeing random fails and can't get the tests to run successfully. Do you think it could be worth faking the API requests and design the tests against a static definition of what the API expects, rather than have the tests test the API itself?

Feels to me that it would be efficient to test the code in isolation by abstracting the API calls.

t3chnoboy commented 8 years ago

Hey @donovanh! Low API rate limit is a known issue https://github.com/t3chnoboy/amazon-product-api/issues/37 As for the tests, I agree, since the api is stable and has versioning, we can mock it.

masterT commented 7 years ago

I think we should use fixtures and mock the API calls during in test. I created an issue for that #60.