search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
366 stars 104 forks source link

Minnor Fix ASIN Lookup #4

Closed JuanCrg90 closed 9 years ago

JuanCrg90 commented 9 years ago

Added support for the SearchIndex Constraint

Constraint:If ItemIdis an ASIN, a search index cannot be specified in the request. Required for non-ASIN ItemIds.

t3chnoboy commented 9 years ago

Nice catch! :+1: This pull request can't be automatically merged. There are conflicts. Can you rebase it onto master?

git remote add t3chnoboy https:///github.com/t3chnoboy/amazon-product-api.git
git fetch t3chnoboy
git rebase t3chnoboy/master
t3chnoboy commented 9 years ago

hmmm Looks like your branch is 6 commits behind master. It might be difficult to rebase. In this case it might be easier to fork the repo again and add the changes. Or you can just 

git remote add t3chnoboy https:///github.com/t3chnoboy/amazon-product-api.git
git fetch t3chnoboy
git reset --hard t3chnoboy/master
JuanCrg90 commented 9 years ago

Ok, i'll do the second option, thanks for the assistance

JuanCrg90 commented 9 years ago

Done.

I updated my remote repository url to this project :) and i added the change.

Thank you.

t3chnoboy commented 9 years ago

Nicely done!