search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
365 stars 104 forks source link

cannot access TotalResults and TotalPages #41

Closed pgraemer closed 8 years ago

pgraemer commented 8 years ago

i cannot access TotalResults or TotalPages because only the respObj.Items[0].Item is returned.

i would prefer getting the respObj.Items[0] instead of respObj.Items[0].Item.

to not brake older versions you could passing the whole respObj.Items[0] as a second argument to the callback.

pgraemer commented 8 years ago

i was not able to get the test running so the build may fail :(

t3chnoboy commented 8 years ago

Hey @pgraemer! Looks good! All the tests passed locally, so this is good to merge. Can you please update the documentation? Also adding at least one test would be very helpful, but not crucial. What was your problem with running the tests locally?

pgraemer commented 8 years ago

the test problem is a problem on my system, ill check that tomorrow and update docs + tests.

Awesome!

t3chnoboy commented 8 years ago

Danke schön :smile:

pgraemer commented 8 years ago

i updated docs & tests.

All the tests passed locally but travis still complains? i havent used travis so maybe u can help?

t3chnoboy commented 8 years ago

Sure, I'll take a look!