Encode reserved characters of RFC 3986

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client

365 stars 104 forks source link

Encode reserved characters of RFC 3986 #47

Closed baoshan closed 8 years ago

baoshan commented 8 years ago

Without comply with RFC 3986, keywords can not contain !, ', (, ), and *.

Reference implementation is taken from MDN.

Test case supplied.

baoshan commented 8 years ago

This fix solves the The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details. error.

t3chnoboy commented 8 years ago

Nice catch! :+1: Thank you @baoshan!

baoshan commented 8 years ago

Thanks @t3chnoboy! Do you mind pulishing an update when you're free?

t3chnoboy commented 8 years ago

@baoshan Thanks for reminding me! I've updated the package. Sorry it took so long 😞