search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
365 stars 104 forks source link

Don't clobber global promise #52

Closed sethsamuel closed 8 years ago

sethsamuel commented 8 years ago

There's an open thread in es6-promise (https://github.com/stefanpenner/es6-promise/issues/140) to fix this at the library level, but currently the global promise is being clobbered by the "polyfill" even without calling polyfill.

This quick fix avoids that problem.

sethsamuel commented 8 years ago

I ended up doing some additional refactoring while getting the tests to pass. Current test failures are due to the travis secret not decoding, I think.

If you'd prefer a more limited PR I can try to pull out just the promise fix.

t3chnoboy commented 8 years ago

Looks like something's wrong with my amazon credentials. Do the tests pass locally?

sethsamuel commented 8 years ago

Travis secrets don't unlock on PRs (so the values don't leak to any PR requester). You can run the tests locally with the environment variables set to the AWS secrets and they should pass.

t3chnoboy commented 8 years ago

Awesome! Thank you @sethsamuel