search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
365 stars 104 forks source link

Test isolation #74

Closed masterT closed 7 years ago

masterT commented 7 years ago
masterT commented 7 years ago

I invalidated my Amazon API credentials, don't worry.

masterT commented 7 years ago

I did not know how if it was a good idea to test the 'query' of the HTTPS request.

Also I think we should and handle an 500 internal server error.

What do you think?

t3chnoboy commented 7 years ago

I did not know how if it was a good idea to test the 'query' of the HTTPS request.

why not?

Also I think we should and handle an 500 internal server error.

yeah, better error handling would be nice, but I don't think it should be a part of this PR

masterT commented 7 years ago

Should we merge this now and enhance the test later? Or do it now and then merge so we can insert PR #76?

t3chnoboy commented 7 years ago

@masterT 🚢!