search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
366 stars 104 forks source link

Use syntax linter #77

Closed masterT closed 7 years ago

masterT commented 7 years ago

Maybe JavaScript Standard Style?

t3chnoboy commented 7 years ago

Meh, I don't have any preferences. But the airbnb one has much more stars 😝

https://github.com/airbnb/javascript - 46k https://github.com/feross/standard - 9k

masterT commented 7 years ago

But it's less sexy! 😢

t3chnoboy commented 7 years ago

@masterT Good point. giphy-2

t3chnoboy commented 7 years ago

Let's do a ghetto poll: Add 👍 to the option that you prefer @masterT @JuanCrg90 @socketwiz

t3chnoboy commented 7 years ago
  1. Sexy JavaScript Standard Style https://github.com/feross/standard
t3chnoboy commented 7 years ago
  1. Arguably less sexy but definitely more popular Airbnb style guide https://github.com/airbnb/javascript
JuanCrg90 commented 7 years ago

I prefer the Airbnb style, i like the semicolons hehe. we could use the ES5 Styleguide https://github.com/airbnb/javascript/tree/es5-deprecated/es5

Also we could add the editorconfig file http://editorconfig.org/

masterT commented 7 years ago

For everalone 😢

JuanCrg90 commented 7 years ago

Could we close this issue?

masterT commented 7 years ago

Added in PR #90.