search

t3chnoboy / amazon-product-api

:credit_card: Amazon Product Advertising API client
366 stars 104 forks source link

Allow item search with multiple item ids #9

Closed FrankBowers24 closed 9 years ago

FrankBowers24 commented 9 years ago

I have been doing similarity searches which return up to five itemids. I would like to look up all five ids in one call passing in a comma-separted list of ids. If the commas are not escaped I get a cryptic error message from Amazon.

t3chnoboy commented 9 years ago

Hi! Nice addition! Thank you! However the tests are failing. Could you please take a look at them, I'll only have the chance to do so on the weekend. We could use encodeURIComponent function instead of replace(/,/g, '%2C');. What do you think?

FrankBowers24 commented 9 years ago

Yes, encodeURIComponent would be a better choice.

On Wed, May 20, 2015 at 10:05 AM, Dmitry Mazuro notifications@github.com wrote:

Hi! Nice addition! Thank you! However the tests are failing. Could you please take a look at them, I'll only have the chance to do so on the weekend. We could use encodeURIComponent function instead of replace(/,/g, '%2C');. What do you think?

— Reply to this email directly or view it on GitHub https://github.com/t3chnoboy/amazon-product-api/pull/9#issuecomment-103962608 .

t3chnoboy commented 9 years ago

Can you update the method and push --force to this branch?

FrankBowers24 commented 9 years ago

Which branch? develop, master, or streams? I can do it tonight.

On Thu, May 21, 2015 at 2:29 PM, Dmitry Mazuro notifications@github.com wrote:

Can you update the method and push --force to this branch?

— Reply to this email directly or view it on GitHub https://github.com/t3chnoboy/amazon-product-api/pull/9#issuecomment-104425867 .

t3chnoboy commented 9 years ago

master It will automatically update the PR.

FrankBowers24 commented 9 years ago

I don't have access permission to push to your repo. I updated the pull request to use encodeURIComponent.

t3chnoboy commented 9 years ago

Sorry for the late response, I had finals this week. I've checked your branch locally and it worked. Looks like something's wrong with the PR checker. Merging this. Thank you! Great work!