search

t3docs / docker-render-documentation

Render TYPO3 Documentation the official way
https://t3docs.github.io/DRC-The-Docker-Rendering-Container/
20 stars 15 forks source link

Remove Docker Hub references #130

Closed saitho closed 1 year ago

saitho commented 1 year ago

The Docker Hub was removed, so the GHCR image is the only image that can be used. This PR removes all references to the Docker Hub image from source code and documentation to reflect the current state.

I'd like to see a merge into master and stable image tags, so we can fix our pipelines which have been failing since the Docker Hub image was deleted.

Relates to: #129

marble commented 1 year ago

Thank you very much for the PR. It's helpful for me to see which spots are affected. But, I think, I will follow a different plan. And that is: I'd like to use 

 t3docs/render-documentation[:tag]

as a canonical name, that will always be used, independently of the actual container repository, where the Docker image is hosted. It looks like the hoster may change very well these days, now that there are so many image hoster around. So, instead of adding 'ghcr.io/' now "everywhere" in the code, I'll much more require to do a two step process:

# 1. fetch the image from some repo
docker pull MYHOSTER.IO/t3docs/render-documentation[:tag]

# 2. provide under the canonical name
docker tag  MYHOSTER.IO/t3docs/render-documentation[:tag]  t3docs/render-documentation[:tag]

That way I can use the canonical name everywhere in the container and won't have to think about the repo location.