search

t3dotgg / Chrometana

Redirect Bing Somewhere Better
http://Chrometana.Theo.li
MIT License
74 stars 15 forks source link

Chrometana should not redirect Bing searches from the Settings app #16

Closed cfaester closed 8 years ago

cfaester commented 8 years ago

Hi there,

An example of what the subject mentions, would be going to Settings -> Update & Security -> Windows Update tab -> Click the link "Learn More" under "Looking for more info on latest updates".

This takes you to a Bing search, where you get a card with info from Microsoft about this. However, with Chrometana, it takes you to a Google search where no such information is presented. This shouldn't happen.

kyleladd commented 8 years ago

Thanks for bringing this to our attention.

Here are the two instances I found within the settings app and their corresponding links. I think the "form" querystring signifies where the request originated. Settings -> Account -> sync your settings -> how does syncing work http://www.bing.com/search?q=how+do+I+sync+my+settings+in+Windows+10?&filters=guid:%22e28cdb2f-7cd0-437a-b2b1-32565e3b10e7%22%20lang:%22en-us%22&form=S00028

Settings -> Update & Security -> Windows Update -> learn more http://www.bing.com/search?q=check+for+updates+in+windows+10&filters=guid:%228a1ff15d-e8ca-4541-9e73-cfdfd5fed822%22%20lang:%22en-us%22&form=S00028

From my tests, for a Bing search originating:

Thanks,

Kyle

t3dotgg commented 8 years ago

My brief testing in a stock W10 virt confirmed your results. I'm down to fix this over the weekend and ship it in a beta update.

Thanks! -Theo

t3dotgg commented 8 years ago

Kyle's pull request fixes this, expect it in a beta update soon!