Closed kyleladd closed 9 years ago
I was 50/50 on doing this initially due to the overhead of making 2 web requests in most cases, and the additional permissions needed (we only had 1 permissions at the time).
I think that, now that we've added more permissions, it makes more sense to do it this way, and will test this when next on my W10 machine
Ah man, not laughing. My apologies for making people nervous about the increased permissions. Lesson learned.
I think I can remove that "tabs" permission and make a different fallback on Chrome start utilizing content scripts(to initiate the redirect) and message passing(interacting with background js: chrome storage+getURL function).
No worries - if you can get the functionality to continue to behave this way without requesting Tabs permission that'd be great, but don't worry about it too much if you can't. I was planning on removing the background permissions tonight and seeing if your changes are reliable enough to replace all other fallbacks.
If Chrome is not allowed to "Continue running background apps when Google Chrome is closed" (chrome://settings/->Show advanced settings->System), Chrometana was not redirecting from Bing to the preferred search engine.