t3knomanzer / maxmix-software

Maxmix volume mixer software repository
https://maxmixproject.com
Apache License 2.0
126 stars 31 forks source link

New output mode #167

Closed t3knomanzer closed 4 years ago

t3knomanzer commented 4 years ago

Issues

Description

Implemented new output mode based on feedback from @quadbyte and @XScorpion2 . I got rid of the functionality to adjust the volume of different devices independently since it was over complicating the user experience in the device for a use case that may not be very common or even existent.

The new version brings back the simplified master volume edit screen and adds device switching to it. Tapping once takes you to device selection mode, tapping once will switch to that output device and take you back to the volume edit screen.

Types of changes

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

t3knomanzer commented 4 years ago

I'm missing the method to call to do the actual switching of the default endpoint. I have tried to find what @XScorpion2 mentioned but couldn't find it anywhere. Help in that front would be supper appreciated.

Everything else should be working and ready for review.

quadbyte commented 4 years ago

Reviewed and tested, looking good to me. Just need to actually change output.