Converted Display.ino to Display.cpp and performed a pass on code cleanup in Display.cpp. In addition, remove the default adafruit logo bitmap. Compile output summary for firmware size from platformio:
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] Requested changes are in a branch
[x] Compiled and tested requested changes on target hardware (PC, device)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Issues
Description
Converted Display.ino to Display.cpp and performed a pass on code cleanup in Display.cpp. In addition, remove the default adafruit logo bitmap. Compile output summary for firmware size from platformio:
Before: RAM: [====== ] 59.5% (used 1219 bytes from 2048 bytes) Flash: [========= ] 86.5% (used 26562 bytes from 30720 bytes)
After: RAM: [====== ] 59.2% (used 1213 bytes from 2048 bytes) Flash: [======== ] 77.9% (used 23932 bytes from 30720 bytes)
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...