t3knomanzer / maxmix-software

Maxmix volume mixer software repository
https://maxmixproject.com
Apache License 2.0
126 stars 31 forks source link

The MaxMix device should wake up when editing rgb colors on the app #215

Open maelremrem opened 4 years ago

maelremrem commented 4 years ago

Guidelines

Is your feature request related to a problem? Please describe. Is the device is in sleep you can see the colors when you edit them in the app.

Describe the solution you'd like When the app is open the device or at least the leds should be on to see the new colors.

Describe alternatives you've considered Wake up the device but turning the encoder

SchemingWeasels commented 4 years ago

RGB is not part of the settings message. I think we should include it in. But either way, it will have to wait for comms rework.

Edit: RGB is in settings. ProcessPackage returning true does not update activity time. Was dropped somewhere.

XScorpion2 commented 4 years ago

In MaxMix.ino, change this:

    g_DisplayDirty = (command >= Command::SETTINGS || command <= Command::VOLUME_ALT_CHANGE);
    if (command == Command::CURRENT_SESSION || command == Command::ALTERNATE_SESSION ||
        command == Command::VOLUME_CURR_CHANGE || command == Command::VOLUME_ALT_CHANGE)
    {
        g_LastActivity = g_Now;
        g_DisplayDirty = true;
    }

To this:

    if (command >= Command::SETTINGS || command <= Command::VOLUME_NEXT_CHANGE)
    {
        g_LastActivity = g_Now;
        g_DisplayDirty = true;
    }