search

t3l3machus / Villain

Villain is a high level stage 0/1 C2 framework that can handle multiple TCP socket & HoaxShell-based reverse shells, enhance their functionality with additional features (commands, utilities) and share them among connected sibling servers (Villain instances running on different machines).
Other
3.73k stars 602 forks source link

Fix none major issues. #38

Closed Scot-Survivor closed 1 month ago

Scot-Survivor commented 1 year ago

Within this PR are primarily formatting fixes to follow the PEP8 styling code standards that python should follow.

Most notable is the syncing of tabs, to 4 spaces across all python files in the project.

Furthermore, I also fixed a logic bug within the method used to time out if the core doesn't initialise in time. Because of the way the, while loop was constructed, it would quit prior to the timeout being exceeded.

Some spelling mistakes were also fixed.

rilysh commented 1 year ago

Why too many commits instead just three or the highest five? I saw you've committed to very few changes, especially typo and indentation stuff which can be specified in just one or two commits (if you want to split typos from indentation) Overall it's harder to determine the changes which are made.

t3l3machus commented 1 month ago

Hi @Scot-Survivor, There's been a lot of changes since you made this pull request (my bad, I was too busy to check every issue and PR). Additionally, there are too many conflicts atm, so unfortunately I will close this. If you're still willing to contribute, please work on the dev branch which is ahead of main. Logic bugs, spelling mistakes and improvements are welcome, I'm a bit negative about messing with the formatting of all files right now, it's something I would prefer to do myself. Thanks again for taking the time to contribute. Cheers