t3n / helm-charts

Helm charts
MIT License
78 stars 88 forks source link

Update Snipe-IT Helm Chart to Support Manually Created DB Configuration Secret and External Manifests #187

Closed cesarempathy closed 1 year ago

cesarempathy commented 1 year ago

Description:

This pull request enhances the Snipe-IT Helm chart by providing more flexibility and customization options for users. The updates allow users to utilize a manually created Kubernetes secret for managing database configuration and support the use of external manifests for additional resources or configurations.

Benefits:

  1. Manually created DB configuration secret:

    This update allows users to manage database secrets outside the Helm chart, which provides several benefits: a. Improved security: Users can manage sensitive database credentials with more control and restrict access to the secret. b. Reusability: If multiple instances of the Snipe-IT application are deployed in the same cluster, users can reuse the same secret without duplicating sensitive information in multiple secrets. c. Flexibility: Users can leverage existing secret management solutions to manage the database secrets and can update the secret without redeploying the Snipe-IT Helm release.

  2. External manifests support:

    This enhancement allows users to include additional Kubernetes manifests for custom resources or other configurations, offering several advantages: a. Customization: Users can add custom resources or configurations, such as ConfigMaps, additional Secrets, or Ingress resources, without modifying the Snipe-IT Helm chart directly. b. Integration: Users can integrate Snipe-IT with other applications or services by deploying additional resources required for the integration, such as sidecar containers or custom network policies. c. Easier maintenance: As external manifests are decoupled from the core Helm chart, it becomes easier to maintain and upgrade the Snipe-IT Helm chart without losing custom configurations.

mschmidt291 commented 1 year ago

LGTM @jnmcfly