search

t3n / neos-debug

Adds a debug panel to your Neos CMS website
MIT License
30 stars 16 forks source link

BUGFIX: prevent invalid return type error #169

Closed MCStreetguy closed 2 years ago

MCStreetguy commented 2 years ago

Removes most of the fixed return types inside the ContentCacheSegmentAspect class, as proposed in the linked issue.

Fixes #168

MCStreetguy commented 2 years ago

Unfortunately, I still had to touch up my changes several times due to errors in CircleCI, so I just squashed my commits to keep the history as clean as possible. I hope everything is okay now and can be merged, but I'd be happy to receive further input.

MCStreetguy commented 2 years ago

You are absolutely right! I have changed the return types directly in all uses of the function to avoid a follow up error, but the ContentCache can indeed return nothing else than strings. I'll adjust the code right away and also include your proposed return type description. Thank you a lot for your review.

MCStreetguy commented 2 years ago

With pleasure! I am glad that I could contribute a part.