t4t5 / sweetalert

A beautiful replacement for JavaScript's "alert"

https://sweetalert.js.org

MIT License

22.4k stars 2.84k forks source link

fixes default for input elements #771

Closed alex-osman closed 6 years ago

alex-osman commented 6 years ago

Fixes: #764: Input returns empty string if defaultValue not changed
Now the return value is initialized to the value of the input element
- This is STILL an empty string "" if no default value is supplied
- If default value is hello world, submitting the swal will now return hello world

pkeuter commented 6 years ago

@alex-osman Thank you for fixing this! @t4t5 Do you think it's possible that this can be merged for the next release?

alex-osman commented 6 years ago

bump @t4t5

t4t5 commented 6 years ago

Thanks for the PR! Works well!

bandtank commented 5 years ago

This is still happening.

jaspreetsinghchhabra commented 5 years ago

The issue still exists on version 2.1.2.

GregJArnold commented 5 years ago

774 reverted this code... @alex-osman, was this intentional? If so, can you (or @t4t5) re-open this and comment why the fix was backed out? If not, can you submit another PR?

foxtrime commented 2 years ago

same problem