search

t4t5 / sweetalert

A beautiful replacement for JavaScript's "alert"
https://sweetalert.js.org
MIT License
22.4k stars 2.84k forks source link

Allow setting user level button defaults #804

Open jsainthilaire opened 6 years ago

jsainthilaire commented 6 years ago

This fixes #785 @matthew-inamdar @t4t5

jsainthilaire commented 6 years ago

@lionralfs I manually changed it back, everyone should be aware that running webpack for this might change it. Thanks for the input on this.

jsainthilaire commented 6 years ago

ok, it has to do with the this https://github.com/t4t5/sweetalert/blob/master/src/core.ts#L32 in the actual code the namespace is not optional so when you transpiled it will generate the typings file without the optional argument.

jsainthilaire commented 6 years ago

@lionralfs this #805 will fix this behavior.

matthew-inamdar commented 6 years ago

Is this going to be merged at any point soon? Really looking forward to this feature!

jsainthilaire commented 6 years ago

@lionralfs are you guys moving forward with this?

matthew-inamdar commented 6 years ago

Hey @lionralfs I can see you are the reviewer for this PR - is there any info you give on when this feature might be merged? Thanks!