search

t4t5 / sweetalert

A beautiful replacement for JavaScript's "alert"
https://sweetalert.js.org
MIT License
22.4k stars 2.84k forks source link

componentWillUnmount doesn't get triggered #836

Open goldylucks opened 6 years ago

goldylucks commented 6 years ago

to reproduce:

  1. create a swal with react component in the contents
  2. console.log in componentWillUnmount
  3. close the swal
  4. see nothing printed to the console

Inspection of the dom shows that the contents of the modal aren't removed, only hidden by styles.

I can provide a PR with some guidance :)