search

t4t5 / sweetalert

A beautiful replacement for JavaScript's "alert"
https://sweetalert.js.org
MIT License
22.4k stars 2.84k forks source link

Minified 2.1.0 on NPM is not the correct version #847

Closed pkeuter closed 6 years ago

pkeuter commented 6 years ago

For example this PR: https://github.com/t4t5/sweetalert/pull/771 is not implemented in https://registry.npmjs.org/sweetalert/-/sweetalert-2.1.0.tgz, col 35630 says this: setTimeout(function(){t.focus(),a.setActionValue("")},0)} while with the PR this should have been changed to setTimeout(function(){t.focus();var e=t.value;a.setActionValue(e)},0)}

Maybe something went wrong while building the 2.1.0 version? @t4t5 Is there a way we can get the correct version on NPM?

Thanks!

pkeuter commented 6 years ago

Okay apparently I didn't see this has been reverted in: https://github.com/t4t5/sweetalert/commit/d1fe279b2d293693b8345554f7043f254172ccb5. Why has this been reverted?