search

t6d / smart_properties

Ruby accessors on steroids
MIT License
177 stars 20 forks source link

fix some examples in readme and adds ruby syntax highlighting #3

Closed nodo closed 11 years ago

nodo commented 11 years ago

Hi, This is a little fix to the first example you put in the readme and few other fixes to the markdown.

I love your project! :)

Cheers

t6d commented 11 years ago

Thanks for the effort! I'm glad you like the project!

There is a small problem with your pull request though. I think, fenced codeblocks must not be indented with 4 spaces. Github is not displaying the code blocks properly. Please fix that. Then I happily merge your pull request.

nodo commented 11 years ago

@t6d you are totally right, now it should be ok!

nodo commented 11 years ago

BTW: I mess up with git, for the "real" fix see: https://github.com/nodo/smart_properties/commit/11e95835c5a59ddfed6e664c15a012696188f623

t6d commented 11 years ago

Thanks! I'll probably squash all commits into a single one and forcefully push it to Github. I hope Git is smart enough to retain you as author.