t9md / atom-cursor-history

Cursor position history manager
https://atom.io/packages/cursor-history
MIT License
59 stars 7 forks source link

Doesn't work well with atom v1.13.1 #27

Open NKjoep opened 7 years ago

NKjoep commented 7 years ago

Hi!

I installed this package yesterday and I noticed it doesn't work as expected with atom 1.13.1 (osx).

It stops jumping back in the history just after 2 or 3 positions and it seems unable to go forward.

I'd like to describe it better in order to help you find out what is going on but I am not sure of what kind of data you need.

t9md commented 7 years ago

Precise reproduction process is enough, what file, your setting, version, keystroke. And your expectation for each result of each steps(if result was not fit your intention). This package is used for many users and this report is first time. So need precise steps I can reproduce issue to help you. Thanks.

NKjoep commented 7 years ago

Please have a look to this video: image

'.editor':
  'alt-cmd-\\': 'editor:toggle-soft-wrap'

'.platform-darwin atom-text-editor:not([mini])':
  'cmd-shift-v': 'clipboard-plus:toggle'

'body.platform-darwin':
  'cmd-c':            'core:copy'
  'cmd-v':            'core:paste'
  'cmd-x':            'core:cut'
  'ctrl-c':            'core:copy'
  'ctrl-d':           'editor:delete-line'
  'ctrl-f':           'find-and-replace:show'
  'ctrl-v':            'core:paste'
  'ctrl-x':            'core:cut'

'.platform-darwin atom-text-editor':
  'alt-d': 'expand-region:expand'
  'alt-f': 'expand-region:shrink'
  'alt-backspace':    'editor:backspace-to-beginning-of-word'
  'alt-delete':       'editor:delete-to-end-of-word'
  'alt-left':         'editor:move-to-beginning-of-word'
  'alt-right':        'editor:move-to-end-of-word'
  'alt-shift-left':   'editor:select-to-beginning-of-word'
  'alt-shift-right':  'editor:select-to-end-of-word'
  'cmd-alt-l':        'atom-beautify:beautify-editor'
  'cmd-ctrl-d':       'find-and-replace:select-all'
  'cmd-ctrl-l':       'jscs-fixer:fix'
  'cmd-d':            'find-and-replace:select-next'
  'cmd-f':      'find-and-replace:select-undo'
  'cmd-k':            'bracket-matcher:remove-matching-brackets'
  'cmd-left':         'editor:move-to-first-character-of-line'
  'cmd-m':            'bracket-matcher:go-to-matching-bracket'
  'cmd-right':        'editor:move-to-end-of-screen-line'
  'cmd-shift-m':      'bracket-matcher:select-inside-brackets'
  'ctrl-d':           'editor:delete-line'
  'ctrl-shift-left':   'editor:select-to-beginning-of-word'
  'ctrl-shift-right':  'editor:select-to-end-of-word'

'.platform-darwin atom-workspace atom-text-editor:not([mini])':
  'alt-cmd-down':     'editor:duplicate-lines'
  'alt-down':         'editor:move-line-down'
  'alt-up':           'editor:move-line-up'
  'cmd-a':            'core:select-all'
  'cmd-down':         'inc:dec'
  'cmd-left':         'editor:move-to-first-character-of-line'
  'cmd-m':            'bracket-matcher:go-to-matching-bracket'
  'cmd-right':        'editor:move-to-end-of-screen-line'
  'cmd-shift-left':   'editor:select-to-first-character-of-line'
  'cmd-shift-m':      'bracket-matcher:select-inside-brackets'
  'cmd-shift-right':  'editor:select-to-end-of-line'
  'cmd-up':           'inc:inc'
  'ctrl-d':           'editor:delete-line'

'.platform-darwin, .platform-darwin .command-palette atom-text-editor':
  'alt-cmd-left':     'pane:show-previous-item'
  'alt-cmd-right':    'pane:show-next-item'
  'cmd-d':            'find-and-replace:select-next'
  'ctrl-d':           'editor:delete-line'

'.platform-darwin .tree-view, .platform-linux .tree-view':
  'cmd-c':            'core:copy'
  'cmd-v':            'core:paste'

'atom-workspace':
  'ctrl-i':     'cursor-history:next'
  'ctrl-o':     'cursor-history:prev'
  'ctrl-cmd-i': 'cursor-history:next-within-editor'
  'ctrl-cmd-o': 'cursor-history:prev-within-editor'

settings

t9md commented 7 years ago

hmm, sorry I have things to do, I rarely see video. In most case I cannot understand point(I'm not accessible at this time your video because of my environment) Describe it by text with your expectation, at this point I can not understand what the issue is in the first place.

NKjoep commented 7 years ago

It is a short video demonstrating what is wrong.

Anyway this is what happens:

Expected behaviour:

Note:

t9md commented 7 years ago

So you want to wrap from oldest to newest. This is not supported for now.

And your note does please describe it by minimal reproduce procedure. And also want to know if it work when open single file and jump go/back.(not open diffelent file).

Anyway I use this package in daily basis and work well at least for me. So knowing your expectation correctly is always first step before starting actial investigation.

NKjoep commented 7 years ago

No sorry, maybe my explanations was misleading. I don't want to go from the oldest to the newest, I'd like to use as intended :)

As I already said, I am not able to use also with only one file. I press the shortcut to go back in the cursor history, it moves the cursor accordingly but this happens only 2 times. At the moment to go the third position in the history it stops working.

t9md commented 7 years ago

Let's talk using actual file. Place sample file on gist, with marking cliking position by x-1, x-2 text or something. Since I can use it and all test spec passes, so i need to know what you really saying.

hew commented 7 years ago

I can confirm this one also.


Actual behaviour: Press ctrl + o 3 times, cursor moves back 2 positions.

Expected behaviour: Press ctrl + o 3 times, cursor moves back 3 positions.


Actual behaviour: Press ctrl + i 1 times, cursor moves forward 0 positions.

Expected behaviour: Press ctrl + i 1 time, cursor moves forward one position.