Closed aki77 closed 7 years ago
I checked and now understand why it's not work. I'm not hyperclick user currently.
I'll back when I'm motivated to support hyperclick. Here is memo what I investigated very quickly.
What cursor-history package doing on normal mouse click event is( normal mouse click just move cuursor to clicked position )
100ms
of mouse-event bubbling phase(at this point, cursor is at new position)But when hyperclick click, it won't fire 2nd mouse-event bubbling phase, in other word, hyperclick intentionally prevent propagation of mouse event. So cursor-history have no chance to know the timing to compare with old and new locaiton.
The fix idea is to start observation of cursor position change on captureing phase of click.
Then cursor position was changed, compare location(filePath, position).
I'm intentionally basically avoiding to use editor.onDidChangeCursorPosition
I used in old code of this package, but removed to avoid mis-memorizing history because of so many package update cursor position with intent or without intent, that mess up history(means save useless cursor position, e.g just cmd-r to refer symbols-view update cursor position and update history if I natively use onDidChangeCursorPosition
).
Will back when I have time, thanks for input!
Thank you for your help. 😄 I can wait.
I haven't checked throughly, do you have time to check the behavior from this repo?
CHANGES from released version are
Noted with thanks!
It's a perfect! Thank you. 👍
OK, thanks, maybe release at tomorrow. Thanks for checking how it works, was great help 👍
It would be nice if support for hyperclick.