search

t9md / atom-cursor-history

Cursor position history manager
https://atom.io/packages/cursor-history
MIT License
59 stars 7 forks source link

Leak subscriptions #4

Closed aki77 closed 9 years ago

aki77 commented 9 years ago

Please check.

Gyazo

t9md commented 9 years ago

Oh, thanks, I didn't know the way to check subscription leak you reported. Thanks for that, I will check.

aki77 commented 9 years ago

Thank you!

similar problem

t9md commented 9 years ago

Let me check, the reason you are saying 'Leak' is for very large number like 177 or 185 or disposable increased after opening file? For every TextEditor instance, cursor-history add subscription to monitor cursor position change, so increasing disposable itself is not issue.

Anyway I should dispose subscription each time TextEditor destroyed, current implementation is not doing this. Maybe separate subscription management is required.

Oh, I'll check similar problem you just posted thanks again.

t9md commented 9 years ago

I read similar problem issue. Understood problem, I'll fix that.

t9md commented 9 years ago

Thanks for report, I believe its fixed!

aki77 commented 9 years ago

Thanks for awesome package!

t9md commented 9 years ago

Oh, you use my package, I'm very glad to know, thanks!.