Use narrow editor(instead of current mini-input-form) to read search-term on search/atom-scan - Githubissues

t9md / atom-narrow

narrow something

https://atom.io/packages/narrow

MIT License

109 stars 12 forks source link

Use narrow editor(instead of current mini-input-form) to read search-term on search/atom-scan #51

Closed t9md closed 7 years ago

t9md commented 7 years ago

Currently, atom-scan and search provider use mini input form to read user-input. Which input is passed to ag or atom.workspace.scan.

But Is it necessary? Let's evaluate use narrowEditor for this purpose.

What will change.

narrowEditor(ui)'s first query keyword is treated as search-term(passed to ag)
Benefit is: Whenever user re-search in different keyword, user can directly edit it.
narrowEditor will be opened BEFORE user specifying search-term.
- Good for internal code consistency.
- Good for easily restorable full-state of narrow-editor.

t9md commented 7 years ago

Infinitely postpone, I haven't evaluated, but don't feel this necessity for now.