t9md / atom-quick-highlight

Highlight text quickly
https://atom.io/packages/quick-highlight
MIT License
32 stars 7 forks source link

Provide onDidHighlght hook #13

Closed t9md closed 7 years ago

t9md commented 7 years ago

fix #12 To create minimap plugin without mess

Things to consider

t9md commented 7 years ago

ServiceProvider(=quick-highlight)

ServiceConsumer: 3rd party package which use quick-highlight service

  consumeQuickHighlight(quickHighlightService) {
    const boundHandler = this.onChangedHighlights.bind(this)
    this.subscriptions.add(quickHighlightService.onDidChangeHighlight(boundHandler))
  },
gouegd commented 7 years ago

Hi t9md, is there any blocker on this, that I could help with ?

t9md commented 7 years ago

No if you agree with that I will merge it.

gouegd commented 7 years ago

I'm happy with the exposed service, thanks 👍 I will publish the minimap integration on apm when this is merged an published too.

t9md commented 7 years ago

Close in favor of #17. And will send PR to you minimap-plugin soon.