esc then press ":" have no response

t9md / atom-vim-mode-plus-ex-mode

Experiment to implement ex-mode for vim-mode-plus

https://atom.io/packages/vim-mode-plus-ex-mode

MIT License

30 stars 11 forks source link

esc then press ":" have no response #21

Closed spellforce closed 7 years ago

spellforce commented 7 years ago

Check this

sdwilsh commented 7 years ago

Seeing this as well: Atom : 1.12.7 Electron: 1.3.13 Chrome : 52.0.2743.82 Node : 6.5.0 vim-mode-plus: 0.66.1 vim-mode-plus-ex-mode: 0.7.1

fazlearefin commented 7 years ago

I am getting the same issue - typing ':' has no response.

Atom : 1.13.0 Electron: 1.3.13 Chrome : 52.0.2743.82 Node : 6.5.0 vim-mode-plus: 0.80.0 vim-mode-plus-ex-mode: 0.7.1

t9md commented 7 years ago

Give me precise steps which can reproduce this with high percentage? Currently provided information is too small to make me think to start investigating.

fazlearefin commented 7 years ago

Steps to reproduce this on my system:

(I have both vim-mode-plus and vim-mode-plus-ex-mode installed. Versions listed above. I do not have vim-mode or ex-mode installed)
launch atom
File > New File
Press i to go to insert mode
write something
press ESC to get out of insert mode
type :w (I was expecting the file to be save but nothing happens)

t9md commented 7 years ago

Tried but failed to reproduce.

Can you reproduce 100%? What OS are you using?
Can you narrow down the condition this issue would happen? what keybinding-resolver saying when : was not show vmp-ex-mode dialog(reproduce issue by enabling keybinding-resolver via cmd-. then repro/observe the reaction for the keystroke :).
When : do nothing, can you still invoke ex-mode:open from command-palette?

I need answer for ALL the question above to understand issue correctly.

dalehille commented 7 years ago

Can you reproduce 100%? What OS are you using? Yes, on macOS Sierra 10.12.2 for me
Can you narrow down the condition this issue would happen? what keybinding-resolver saying when : was not show vmp-ex-mode dialog(reproduce issue by enabling keybinding-resolver via cmd-. then repro/observe the reaction for the keystroke :).
_When : do nothing, can you still invoke ex-mode:open from command-palette? Yes

fazlearefin commented 7 years ago

Can you reproduce 100%? What OS are you using? Yes. Ubuntu GNOME 16.10
Can you narrow down the condition this issue would happen? what keybinding-resolver saying when : was not show vmp-ex-mode dialog(reproduce issue by enabling keybinding-resolver via cmd-. then repro/observe the reaction for the keystroke :). Same as the previous comment by @dalehille
When : do nothing, can you still invoke ex-mode:open from command-palette? No

aouaki commented 7 years ago

Did you add the keymap ?

'atom-text-editor.vim-mode-plus.normal-mode':
  ':': 'vim-mode-plus-ex-mode:open'
  '!': 'vim-mode-plus-ex-mode:toggle-setting'

dalehille commented 7 years ago

Thanks @aouaki , that resolved it for me

fazlearefin commented 7 years ago

Thanks @aouaki . Fixed.

fazlearefin commented 7 years ago

@t9md I think the readme needs to be updated to provide a clearer instruction on adding the keymap. Edit > Keymap, then paste

'atom-text-editor.vim-mode-plus.normal-mode':
  ':': 'vim-mode-plus-ex-mode:open'
  '!': 'vim-mode-plus-ex-mode:toggle-setting'

t9md commented 7 years ago

Will provide default keymaps so that I and other new users no longer spend time for this issue.

sdwilsh commented 7 years ago

That'd be ideal :)

The ex-mode plugin for vim-mode did that, and that's why I thought it was broken in this one.

t9md commented 7 years ago

From v0.8.1 no longer need custom keymaps(v0.8.0 was unpublished in 5min after release, just was mistake).

t9md commented 7 years ago

Thanks @dalehille for your help.

t9md commented 7 years ago

Oh, I should say thanks to you @aouaki . sorry, above my comment was intended to do that, just mistake 😅