search

t9md / atom-vim-mode-plus

vim-mode improved
https://atom.io/packages/vim-mode-plus
MIT License
1.4k stars 111 forks source link

Hide all editor commands in command palette #1033

Closed ykpythemind closed 6 years ago

ykpythemind commented 6 years ago

Count of 'vim-mode-plus:' commands which are shown in command palette is over 320. (gather from command-table-pretty.json) Sometimes it is annoying when I open command palette. (I think it slows down fuzzy searching)

So I want to set hiddenInCommandPalette: true

ref: https://github.com/t9md/atom-vim-mode-plus/commit/e93bf233111e872f0cad354d8d143b0161335fd1

t9md commented 6 years ago

I believe no noticeable(at least as human level) slow down is exists. Anyway I agree sometime reducing number of candidates command improve find-ability of commands in palette.

Since I still it's useful to be able to execute rarely used command from palette. I want make it optional and want to be careful which command to hide, so I'll try to implement this by myself.

t9md commented 6 years ago

change mind, will merge this and just make it configurable afterward. Thanks.

ykpythemind commented 6 years ago

@t9md

Thank you for merging.

I believe no noticeable(at least as human level) slow down is exists.

I think so too, but I feel this change makes faster a little when I use command palette. ( it is command palette package issue?

Since I still it's useful to be able to execute rarely used command from palette.

yes. but I just noticed it is useful to be able to see which command is available. I have not used Vim for a long time, so I haven't tried special features like occurrence. I think it is useful I can see just like a cheat sheet panel instead of command palette.

t9md commented 6 years ago

I think so too, but I feel this change makes faster a little when I use command palette. ( it is command palette package issue?

This is my comment about perf gain by this hidden feature. https://github.com/atom/command-palette/pull/92#issuecomment-342093729

Actual perf gain will come from this PR. You can check by using atom-beta v0.25.0 now. https://github.com/atom/command-palette/pull/101

For cheat sheet purpose, go to setting-view(cmd-,) > Keybindings then search vim-mode-plus:. Or see bottom keymap section of vim-mode-plus's setting-veiw.

ykpythemind commented 6 years ago

OK, I got it. Thank you so much!