t9md / atom-vim-mode-plus

vim-mode improved
https://atom.io/packages/vim-mode-plus
MIT License
1.4k stars 111 forks source link

shift-escape should return to command mode #1145

Open notinaboat opened 3 years ago

notinaboat commented 3 years ago

It feels like atom-vim-mode-plus is sometimes ignoring my escape keypress when I type fast. I think it is because escape is ignored if shift is held down. In Vim and in terminal vi, the escape key returns to command mode even if shift is held down. After 25 years of vi-ing, my brain is not capable of adjusting :)

I have this problem every time I want to comment out a few lines of code by inserting a # at the start of the line.

I start with this:

    fo[o]
    bar

I do: 0, i, shift-down, #,escape, j, i, shift-down, #, escape, j.

I expect to get this:

#    foo
#    bar
[]

But if the shift-up happens after the escape then I get this:

#ji#j[]    foo
    bar
debug info ```json { "atom": "1.53.0", "platform": "darwin", "release": "19.6.0", "vmpVersion": "1.36.4", "vmpConfig": {} } ```
keevan commented 2 years ago

FWIW @notinaboat I tried adding this to my atom/keymap.cson with some level of success.

'atom-text-editor':
    'shift-escape': 'vim-mode-plus:activate-normal-mode' # Shift Escape to return to normal mode

You may need to reload the editor after applying these changes (I had to..)

Hope that helps :)