vim-mode-plus prevents notifications from being dismissed

matthewwithanm commented 7 years ago

Atom notifications can't be dismissed using escape when vim-mode-plus is installed. To repro:

Trigger a notification (atom.notifications.addError('hi'))
With the editor focused, hit esc. (Nothing happens.)
Trigger "Core: Cancel" from the command palette to see how it should work.

Atom version: 1.19.0-beta4
vim-mode-plus version: 0.94.0
OS: macOS Sierra 10.12.4
vim mode not installed
Tried to latest stable atom version with latest vim-mode-plus.

t9md commented 7 years ago

Yes, this is currently limitation of vim-mode-plus. In vim-mode-plus, escape is not mapped to core:cancel. It's mapped to vim-mode-plus:activate-normal-mode(not in normal-mode) or vim-mode-plus:reset-normal-mode. This is the implementation taken over from original vim-mode(github maintained), I can FIX this limitation by overloading core:cancel but postponed, since impact is big.

So currently what user can do is set dedicated keymap for core:cancel(what I'm doing now).

See this comment for detail.

https://github.com/t9md/atom-vim-mode-plus/issues/526#issuecomment-262701696

ghost commented 6 years ago

What is the function of reset-normal-mode? Does it need three keymaps?

https://github.com/t9md/atom-vim-mode-plus/blob/2e255afd8f8ea21ddf523d929807c1cf3f13102a/keymaps/vim-mode-plus.cson#L12-L17

t9md / atom-vim-mode-plus

vim-mode-plus prevents notifications from being dismissed #813