search

t9md / atom-vim-mode-plus

vim-mode improved
https://atom.io/packages/vim-mode-plus
MIT License
1.4k stars 112 forks source link

Potential keymapping bug or incompatibility with proton-mode #860

Closed jackcasey closed 7 years ago

jackcasey commented 7 years ago

Please see this issue: https://github.com/dvcrn/proton/issues/286#issuecomment-326710634

It seems that since a recent version of vim-mode-plus (0.99.0) something has changed with key mapping? (In particular the g key?)

I've reproduced this in quite a minimal install of both proton-mode and vmp.

I can't reproduce it with just vmp however; so I guess it's some interaction between the keymapping in vmp and in proton, probably the way in which they both do 'modal' key mapping?

Atom : 1.19.5 Electron: 1.6.9 Chrome : 56.0.2924.87 Node : 7.4.0

I will update both issues if I find anything more interesting.

t9md commented 7 years ago

Is this understanding correct?

Don't need to answer, I read related proton issue, the above understanding is correct.

t9md commented 7 years ago

diff from v0.98.0-v0.99.0 https://github.com/t9md/atom-vim-mode-plus/compare/v0.98.0...v0.99.0

For keymap, it adds g 0, g ^, g $ keymap. That is super normal addition, I don't think it problematic. Even if it have some conflicts in keymap with proton, throwing exception is bug of atom-keymap. I think you can open it to atom-keymap project.

I'm now trying to reproduce by installing proton(first time), it take so long to install, now waiting to finish.

jackcasey commented 7 years ago

Thankyou very much for looking into it. It definitely might be some limitation or bug in atom-keymap.

Side note: Proton and vmp are a great combo; I love both projects :)

t9md commented 7 years ago

Btw, proton seem to REPLACE all pkgs i've installed, I want recover it. How can I do? manual only?

jackcasey commented 7 years ago

@t9md Proton handles package management from the ~/.proton file.

Inside that file (the file type is like clojure what JSON is to javascript) you can enable and disable 'layers' (bundles of packages defined by proton). And also enable and disable individual packages.

For example to add a package that its not part of a proton layer you can add something like: ~/.proton

  ...

  ;; Packages that are not part of a layer. List them here as keyword
  ;; All packages will be ensured to be installed. Stuff that is not listed here
  ;; Will get uninstalled so choose wisely!
  :additional-packages
  [
    :cursor-history
  ]
  ...

Then when you restart or reload atom it will automatically add that package for you.

jackcasey commented 7 years ago

Feel free to ping me on the atom slack if you need more help.

t9md commented 7 years ago

What i want to do is just RECOVER(uninstall proton/ restore previous pkg state), since my investigation for proton is DONE. I'm now manually recovering each pkgs. If there is better/quick way I want to know.

t9md commented 7 years ago

I didn't know proton replace all locally installed pkgs. I wanted to know before installing proton so that I can preserve pkg directory for easy restore.

jackcasey commented 7 years ago

Oh, I'm sorry I don't know of a way to restore packages that you had enabled before. I don't know that they're backed up anywhere. I think manual.

This won't help you now; but when I'm testing fresh installs etc in atom I use a different configuration by doing launching atom like this:

ATOM_HOME=~/.atom_testing atom .

So that my old atom configuration isn't modified.

Proton also changes settings as well. I'm really sorry that this caused an inconvenience for you :(

jackcasey commented 7 years ago

FYI: https://github.com/dvcrn/proton/issues/288 :/

t9md commented 7 years ago

Close since as my understanding, vmp do nothing special in it's default keymap. Will re-open if proton's side investigation reveals it's still has something to do with vim-mode-plus.