t9md / atom-vim-mode-plus

vim-mode improved
https://atom.io/packages/vim-mode-plus
MIT License
1.4k stars 112 forks source link

reconcile visual-mode with outer-vmp command in better way(my hope!) #878

Closed t9md closed 7 years ago

t9md commented 7 years ago

Fix #874 and issues which is not reported but definitely exists. Related #873

Now when outer-vmp command modify selection, vmp catch this selection change and start visual-mode accordingly.

But this approach is the one I've tried to avoid because editor.onDidchange is too frequently fired event, and if I'm not careful it can cause infinite loop.

Anyway I cannot find better approach than this for now, so will go this approach!.

t9md commented 7 years ago

This also fix #872