Add setting for allowing/preventing search to wrap around

t9md / atom-vim-mode-plus

vim-mode improved

https://atom.io/packages/vim-mode-plus

MIT License

1.4k stars 112 forks source link

Add setting for allowing/preventing search to wrap around #897

Open johnckendall opened 7 years ago

johnckendall commented 7 years ago

Simple option to prevent search wraparound like the vi option: set nowrap and set wrap

t9md commented 7 years ago

Why did you change repository reference? I can not get your intention. Also, I think your PR have following caveat.(not confirmed, just from code-read).

When there is no match in forwarding direction, it return last match(it should return nothing).

Also I need test spec before merging this(this is depending on content of changes, I sometime accept test-less PR).

johnckendall commented 7 years ago

Sorry, new to this; first PR. I will look into creating a test spec.
About the repo reference; I thought I needed to do this to make sure I get my version locally? Still not sure how this stuff works I guess. Regarding the last match behavior; I left it that way because I like the way it works! ;-) I suppose I could add another option switch to turn it off if you think it is needed. (sorry for late reply, i've been on a cruise in the gulf for last 10 days)