t9md / atom-vim-mode-plus

vim-mode improved
https://atom.io/packages/vim-mode-plus
MIT License
1.4k stars 111 forks source link

[feature] show keybinding search (maybe in Cmd + Shift + P) #997

Open stopachka opened 6 years ago

stopachka commented 6 years ago

Hey team, though I am efficient with atom and vim-mode-plus, I realize I don't use as much of the power as I possibly could.

One thing that helped was a cheatsheet that I printed out.

However, what would be even better would be a "keybinding search" bar, that I could directly and filter in atom.

This is effectively what Command + Shift + P does for keyboard shortcuts. However, right now I could see that vim-mode-plus commands, like "move to end of sentence" are not included.

Two ideas could be:

  1. We include all the keybindings in the bar that shows cmd + shift + p, and preface it with some easy to filter search term. i.e vmp move to end of sentence

  2. Alternatively, we could have our own variant of the search bar, that just searches for vim commands.

These could make new vim users into better vim users much more quickly then today. If this already exists, awesome, if not, happy to take a stab at it -- some pointer to where I could start would be great!

t9md commented 6 years ago

Hi

However, right now I could see that vim-mode-plus commands, like "move to end of sentence" are not included.

Why "end of sentence" not appear on command-palette(cmd-shift-p) is there is no such command vmp provides.

You can find all available command in command-palette. Also you can find it from Keybindings section of setting-view(cmd-,) Plus you can find vmp's keymap directly from https://github.com/t9md/atom-vim-mode-plus/blob/master/keymaps/vim-mode-plus.cson.

motion_js_ ___github_atom-vim-mode-plus 2
stopachka commented 6 years ago

Thanks for the thorough answer @t9md ! If we have things in cmd + shift + p it's awesome!

Here's a weird thing: When I open cmd + shift + p, I do not see the keystroke:

This is what I see: image

This is how the DOM looks: image

However the keystroke shows up in keybindings:

image


Update:

Hm weirdly enough, tried to reload atom:

  1. The first time I reloaded, I no longer saw the sentence recommendation -- image
  2. The second time I reloaded, I saw it, and it showed correctly image

Interesting indeed -- do you think there is some loading bug? Happy to help dig in if you need some logs

t9md commented 6 years ago

There is no bug for loading command. You see all commands available in current target element. You need to open palette in text-editor to see sentence motion, since its only available in text-editor. This is why you see only maximize pane in non-editor target. Why you see maximize-pane in every emelent is I made it available at workspace. Workspace is container of all text-editor in atom. Make sense to you now?

t9md commented 6 years ago

Forgot to comment about keyboard-shutcut. I don’t know why shortcut is not shown in your env. Can you reproduce it?